Closed Bug 1231828 Opened 9 years ago Closed 9 years ago

Fix eslint check in toolkit

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Whiteboard: [backout-asap])

Attachments

(2 files)

A number of xbl files don't pass now that bug 1229858 is landed.
Bug 1231828: Fix XBL preprocesser to properly handle fields, entities and handlers. r?miker Fixing some XBL files turned up some bugs in the preprocessor: * XBL fields aren't just simple JS assignements, they are entire JS blocks which are evaluated and the result used for the field. So we don't need eslint to parse them as an assignment. * XBL text can contain entities, in general just replacing every entity with a valid JS token should retain the meaning well enough for eslint's purposes. * Events can have names that aren't valid JS identifiers so just don't use them.
Attachment #8697633 - Flags: review?(mratcliffe)
Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r?felipe
Attachment #8697634 - Flags: review?(felipc)
Attachment #8697634 - Flags: review?(felipc) → review+
Comment on attachment 8697634 [details] MozReview Request: Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe https://reviewboard.mozilla.org/r/27681/#review24907
Attachment #8697633 - Flags: review?(mratcliffe) → review+
Comment on attachment 8697633 [details] MozReview Request: Bug 1231828: Fix XBL preprocesser to properly handle fields, entities and handlers. r=miker https://reviewboard.mozilla.org/r/27679/#review25067 r+
Comment on attachment 8697633 [details] MozReview Request: Bug 1231828: Fix XBL preprocesser to properly handle fields, entities and handlers. r=miker Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27679/diff/1-2/
Attachment #8697633 - Attachment description: MozReview Request: Bug 1231828: Fix XBL preprocesser to properly handle fields, entities and handlers. r?miker → MozReview Request: Bug 1231828: Fix XBL preprocesser to properly handle fields, entities and handlers. r=miker
Comment on attachment 8697634 [details] MozReview Request: Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe Review request updated; see interdiff: https://reviewboard.mozilla.org/r/27681/diff/1-2/
Attachment #8697634 - Attachment description: MozReview Request: Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r?felipe → MozReview Request: Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Whiteboard: [backout-asap]
This fix appears to have caused a regression when sorting XUL trees in a Remote XUL deployment (based on the output of mozregression). I've filed bug #1279911 with more details and a test case.
Depends on: 1279911
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: